From 5d160d913e03b581bdddde73535c18ac670cf0a9 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Mon, 24 Feb 2014 12:11:01 +0100 Subject: [PATCH] x86/MSI: don't risk division by zero The check in question is redundant with the one in the immediately following if(), where dividing by zero gets carefully avoided. Spotted-by: Boris Ostrovsky Signed-off-by: Jan Beulich Reviewed-by: Boris Ostrovsky --- xen/arch/x86/msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index 1aaceeb8f4..61d6dd09d5 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -636,7 +636,7 @@ static u64 read_pci_mem_bar(u16 seg, u8 bus, u8 slot, u8 func, u8 bir, int vf) return 0; base = pos + PCI_SRIOV_BAR; vf -= PCI_BDF(bus, slot, func) + offset; - if ( vf < 0 || (vf && vf % stride) ) + if ( vf < 0 ) return 0; if ( stride ) { -- 2.30.2